-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite ssc #1982
base: general-devel
Are you sure you want to change the base?
Rewrite ssc #1982
Conversation
Begin rewriting the old implementation
Thanks for the pull request! TShock's maintainers would like you to go ahead and give yourself credit by updating the |
No idea if overridessc and uploadssc commands still work. |
/// <summary> | ||
/// Provides and executes CRUD operations on server side player data | ||
/// </summary> | ||
public class ServerSideCoordinator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this name or this class.
Feels like its trying to do too much at once (hence an ambiguous name like 'Coordinator'), so suggestions on design here would be appreciated
Some test results: -Overridessc and uploadssc commands do not work (Log: Command: ERROR: System.NullReferenceException) Thank for this work! |
This is wildly untested and smashed out in a night.
Some hardcore review (and testing if possible!) would be appreciated.
Pulled as much of the SSC subsystem out of the various handlers and methods it was in as I could and turned it into a first class system. It now hooks things on its own and is hopefully a lot cleaner to look at